Re: [PATCH] pg_sleep(interval)

From: Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [PATCH] pg_sleep(interval)
Date: 2013-10-17 21:01:22
Message-ID: 52605022.3090202@dalibo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/17/2013 06:59 PM, Josh Berkus wrote:
> Our project has a serious, chronic problem with giving new
> patch-submitters a bad experience, and this patch is a good example of
> that. The ultimate result is that people go off to contribute to other
> projects where submissions are easier and the rules for what gets
> accepted are relatively transparent.

That may be true, but it depends on the contributor. I would much
rather be told that my contribution is not up to snuff than what
happened on another project I recently tried to contribute to for the
first time.

A parser refactoring broke my code. I reported it and it was promptly
fixed. When the fix came up for review, I said it needed a regression
test to prevent it from happening again and I was told by the author
that such a test would be "flimsy" and it went on to be committed (by
that same guy) without one. I'm undecided whether I'll be contributing
there any further.

The rigor here makes me want to try and try again.

--
Vik

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-10-17 21:41:03 Re: removing old ports and architectures
Previous Message Vik Fearing 2013-10-17 20:41:29 Re: [PATCH] pg_sleep(interval)