Re: Patch: FORCE_NULL option for copy COPY in CSV mode

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: FORCE_NULL option for copy COPY in CSV mode
Date: 2013-10-10 13:15:28
Message-ID: 5256A870.5000303@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 10/09/2013 11:47 PM, Amit Kapila wrote:
>
> One of the advantage, I could see using "NULL For .." syntax is
> that already we have one syntax with which user can specify what
> strings can be replaced with NULL, now just to handle quoted empty
> string why to add different syntax.
>
> "FORCE_NULL" has advantage that it can be used for some columns rather
> than all columns, but I think for that existing syntax can also be
> modified to support it.
>
>
>

I think it's badly designed on its face. We don't need and shouldn't
provide a facility for different NULL markers. A general facility for
that would be an ugly an quite pointless addition to code complexity.
What we need is simply a way of altering one specific behaviour, namely
the treatment of quoted NULL markers. We should not do that by allowing
munging the NULL marker per column, but by a syntactical mechanism that
directly addresses the change in behaviour. If you don't like "FORCE
NULL" then let's pick something else, but not this ugly and unnecessary
"NULL FOR" gadget.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-10-10 13:23:30 Re: space reserved for WAL record does not match what was written: panic on windows
Previous Message Robert Haas 2013-10-10 12:59:47 Re: space reserved for WAL record does not match what was written: panic on windows