| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: hstore extension version screwup |
| Date: | 2013-09-30 02:33:51 |
| Message-ID: | 5248E30F.6070404@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/29/2013 09:58 PM, Peter Eisentraut wrote:
> On Fri, 2013-09-27 at 13:23 -0400, Andrew Dunstan wrote:
>> This was lazy and there's no real excuse, although I will note that it
>> was a mistake far too easy to make. Perhaps as a warning indicator we
>> should remove write permissions from these files.
> What do you mean by that?
Well if these are not meant to be changed then not being able to write
them in your git repo might be a clue to that.
Just a thought.
>
>> See attached for details of what's proposed.
> see broken builds on build farm
>
>
>
Yeah, looks like I forgot about the make file. I did test this but with
a manual install. Will fix.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-09-30 02:38:05 | Re: hstore extension version screwup |
| Previous Message | Peter Eisentraut | 2013-09-30 02:32:26 | Re: appendStringInfo vs appendStringInfoString |