| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: warning in code while building on windows |
| Date: | 2013-08-18 21:30:29 |
| Message-ID: | 52113CF5.2030201@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/18/2013 05:08 PM, Alvaro Herrera wrote:
> Amit Kapila escribió:
>> 1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101:
>> 'isnull' : unreferenced local variable
>>
>> It seems this variable is used only under macro USE_ASSERT_CHECKING,
>> so it is better to declare under this macro only.
> We have a macro for this, PG_USED_FOR_ASSERTS_ONLY. This should silence
> it; if the msvc stuff is not picking it up then maybe we need to tweak
> the definition of the macro somehow.
>
The macro is pretty gcc-specific, isn't it?
For MSVC we would probably need to surround the declaration with
something like these lines.
#pragma warning(disable:4101)
#pragma warning(default:4101)
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hannu Krosing | 2013-08-18 21:34:03 | Re: Feature Request on Extensions |
| Previous Message | Kevin Grittner | 2013-08-18 21:28:35 | Re: Materialized views WIP patch |