From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |
Date: | 2013-06-30 20:09:12 |
Message-ID: | 51D09068.8020404@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 06/30/2013 03:50 PM, Jeff Davis wrote:
> On Sun, 2013-06-30 at 11:11 -0700, Jeff Davis wrote:
>> Unless something surprising comes up, or someone thinks and objection
>> has been missed, I am going to commit this soon.
> Quick question to anyone who happens to know:
>
> What is the standard procedure for changes to pg_config.h.win32? I
> looked at an old patch of mine that Tom (CC'd) committed:
>
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b966dd6c4228d696b291c1cdcb5ab8c8475fefa8
>
> and I see that it modifies pg_config.h.win32. Should I modify it in a
> similar way for this fallocate patch?
>
> Right now, pg_config.in.win32 seems a little inconsistent because it has
> an entry for HAVE_POSIX_SIGNALS but not HAVE_POSIX_FADVISE. It says it's
> a generated file, but I don't have a windows environment or MingW.
>
It was originally generated. Since then it's been maintained by hand.
If you need a Windows environment to test on, see the Amazon recipe at
<http://wiki.postgresql.org/wiki/Building_With_MinGW>
cheers
andrew
>
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Nicholas White | 2013-06-30 22:45:31 | Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls |
Previous Message | Jeff Davis | 2013-06-30 19:50:28 | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |