| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Department of Redundancy Department: makeNode(FuncCall) division |
| Date: | 2013-06-28 17:28:35 |
| Message-ID: | 51CDC7C3.7080204@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/28/13 11:30 AM, Robert Haas wrote:
> On Fri, Jun 28, 2013 at 10:31 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> David Fetter <david(at)fetter(dot)org> writes:
>>> Please find attached the latest patch.
>>
>> I remain of the opinion that this is simply a bad idea. It is unlike
>> our habits for constructing other types of nodes, and makes it harder
>> not easier to find all the places that need to be updated when adding
>> another field to FuncCall.
>
> I think it's a nice code cleanup. I don't understand your objection.
Yeah, I was reading the patch thinking, yes, finally someone cleans that up.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-06-28 17:34:17 | Re: Documentation/help for materialized and recursive views |
| Previous Message | Robert Haas | 2013-06-28 17:26:40 | Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls |