Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement)

From: Greg Smith <greg(at)2ndQuadrant(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement)
Date: 2013-06-11 20:22:29
Message-ID: 51B78705.7050603@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/11/13 4:11 PM, Fabien COELHO wrote:
> - ISTM that there "thread start time" should be initialized at the
> beginning of threadRun instead of in the loop *before* thread creation,
> otherwise the thread creation delays are incorporated in the
> performance measure, but ISTM that the point of pgbench is not to
> measure thread creation performance...

I noticed that, but it seemed a pretty minor issue. Did you look at the
giant latency spikes at the end of the test run I submitted the graph
for? I wanted to nail down what was causing those before worrying about
the startup timing.

--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-06-11 20:47:12 Re: Current CLOBBER_CACHE_ALWAYS failures
Previous Message Fabien COELHO 2013-06-11 20:11:37 Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement)