Re: PostgreSQL 9.3 beta breaks some extensions "make install"

On 05/14/2013 07:59 AM, Peter Eisentraut wrote:
> On 5/14/13 4:17 AM, Marti Raudsepp wrote:
>> On Tue, May 14, 2013 at 5:27 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>> On Tue, 2013-05-14 at 04:12 +0300, Marti Raudsepp wrote:
>>>> It's caused by this common pattern in extension makefiles:
>>>> DATA = $(wildcard sql/*--*.sql) sql/$(EXTENSION)--$(EXTVERSION).sql
>>> What is the point of this? Why have the wildcard and then the
>>> non-wildcard term?
>> Because the non-wildcard file is built by the same Makefile (it's
>> copied from the sql/$(EXTENSION).sql file). If it wasn't there, a
>> "make install" from a clean checkout would miss this file.
> If it's built, then it should be listed in DATA_built.

So, AIUI, leaving aside stylistic arguments about use of wildcards, one
solution could be:

DATA_built = sql/$(EXTENSION)--$(EXTVERSION).sql
DATA = $(filter-out sql/$(EXTENSION)--$(EXTVERSION).sql, $(wildcard
sql/*--*.sql))

Is that right?

cheers

andrew