Re: lock support for aarch64

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Mark Salter <msalter(at)redhat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: lock support for aarch64
Date: 2013-05-13 15:36:55
Message-ID: 51910897.6070500@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.05.2013 18:14, Tom Lane wrote:
> Mark Salter<msalter(at)redhat(dot)com> writes:
>> I used the following patch to add lock support aarch64. It is just a
>> copy of the arm support based on gcc builtins. Postgresql built with
>> this patch passes the various tests.
>
> Couldn't we just do
>
> -#if defined(__arm__) || defined(__arm)
> +#if defined(__arm__) || defined(__arm) || defined(__aarch64__)
>
> in the existing ARM code block?

That would imply falling back to swpb instruction also on aarch64, which
won't work.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-05-13 15:48:44 Re: erroneous restore into pg_catalog schema
Previous Message Fabien COELHO 2013-05-13 15:36:28 Re: Add more regression tests for dbcommands