| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add support for logging the current role |
| Date: | 2011-02-18 03:40:26 |
| Message-ID: | 5162.1298000426@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Feb 17, 2011 at 4:53 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> In short, add a bit of overhead at SetUserId time in order to make this
>> cheap (and accurate) in elog.c.
> As Stephen says, I think this is utterly impractical; those routines
> can't ever throw any kind of error.
Why would they need to throw an error? It'd be on the caller's head to
supply the role name along with OID. We can keep the name in a static
buffer of size NAMEDATALEN, so don't tell me about palloc failures
either.
The logging design as it stands seems to me to be a Rube Goldberg device
that is probably going to have corner-case bugs quite aside from its
possible performance issues.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-02-18 03:41:17 | Re: Initial review of xslt with no limits patch |
| Previous Message | Tom Lane | 2011-02-18 03:37:24 | Re: About the performance of startup after dropping many tables |