| From: | Greg Smith <greg(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Proposal for Allow postgresql.conf values to be changed via SQL [review] |
| Date: | 2013-03-21 19:05:44 |
| Message-ID: | 514B5A08.3030306@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/21/13 2:38 PM, Robert Haas wrote:
> Also, while I think that MOST people will probably want a SIGHUP right
> after SET PERSISTENT, I am not sure that EVERYONE will want that. If
> you want it and it doesn't happen automatically, you can always do it
> by hand.
This is a fair position, and since that's how the feature as written
right now works that helps. I think proceeding this way needs to hand
some sort of hint back to the user though, telling them the change isn't
active until SIGHUP. The path I don't want to see if where someone uses
SET PERSISTENT and can't figure out why nothing changed. It should be
as obvious as we can make it to someone that the explicit reload is
necessary.
--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-03-21 19:16:51 | Re: hstore compiler warnings |
| Previous Message | Simon Riggs | 2013-03-21 18:53:15 | Re: Should commit_delay be PGC_SIGHUP? |