| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
| Cc: | 'Phil Sorber' <phil(at)omniti(dot)com>, 'Alvaro Herrera' <alvherre(at)2ndquadrant(dot)com>, 'Magnus Hagander' <magnus(at)hagander(dot)net>, 'PostgreSQL-development' <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq |
| Date: | 2013-02-26 08:06:08 |
| Message-ID: | 512C6CF0.6080301@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 26.02.2013 09:06, Amit Kapila wrote:
> On Monday, February 25, 2013 11:26 PM Heikki Linnakangas wrote:
>> On 21.02.2013 16:09, Amit Kapila wrote:
>>> On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote:
>> I've committed those patches, with some further changes. If you have
>> the
>> time, please take another look at the committed patches. Thanks!
>
> 1. For pg_dumpall, incase user gives dbname in connection string, for ex.
> "user=amit dbname=db_regress port=5434"
> it will be ignored and postgres (default database name) will be used.
Yeah, that is mentioned in the docs. The other option would be to use
the database name from the connection string for the initial connection,
ie. the same as specifying a database name with the -l option. Yet
another option is to throw an error if database name was given. If we
make it an error, then we should make it an error in pg_basebackup and
pg_receivexlog too. I'm all ears for opinions on this.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marios Vodas | 2013-02-26 08:39:09 | GIST_LEAF() causes error in GiST methods union and penalty |
| Previous Message | Kevin Grittner | 2013-02-26 07:48:09 | Re: Floating point error |