Re: Contrib PROGRAM problem

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Contrib PROGRAM problem
Date: 2013-01-19 04:57:47
Message-ID: 50FA27CB.9090005@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 01/18/2013 11:42 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> This patch seems to do the right thing.
> Hmm ... seems kinda grotty ... isn't there a cleaner way?
>
>> It probably needs to be applied to all the live branches.
> Agreed on back-patching once we have the right thing, but I don't like
> this version too much.
>
>

I'm happy of you can find something cleaner.

We can't just have a dependency of all on $(PROGRAM)($X) because if
PROGRAM is empty but X is not it will do something horrid like try to
build ".exe".

If we do it the way Zoltan suggested then on Windows even if
$(PROGRAM)$(X) exists and is up to date it could be rebuilt, since the
target name won't exist.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-01-19 04:59:48 Re: Contrib PROGRAM problem
Previous Message Tom Lane 2013-01-19 04:42:17 Re: Contrib PROGRAM problem