Master fails to build without ldap headers

From: Craig Ringer <craig(at)2ndQuadrant(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: peter_e(at)gmx(dot)net
Subject: Master fails to build without ldap headers
Date: 2012-12-04 06:01:13
Message-ID: 50BD91A9.7020703@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all

While doing some setup I've noticed that master (at least) appears to
fail to build if LDAP headers aren't installed.

gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -I../../../src/include -D_GNU_SOURCE -c -o hba.o hba.c
hba.c: In function 'parse_hba_auth_opt':
hba.c:1388: error: 'LDAP_SCOPE_SUBTREE' undeclared (first use in this function)
hba.c:1388: error: (Each undeclared identifier is reported only once
hba.c:1388: error: for each function it appears in.)
hba.c:1451: error: 'LDAPURLDesc' undeclared (first use in this function)
hba.c:1451: error: 'urldata' undeclared (first use in this function)
hba.c:1452: warning: ISO C90 forbids mixed declarations and code
hba.c:1452: warning: unused variable 'rc'

It looks like this was broken by:

commit aa2fec0a18e4d23272c78916ef318078c920611a
Author: Peter Eisentraut <peter_e(at)gmx(dot)net>
Date: Mon Dec 3 23:29:56 2012 -0500

Add support for LDAP URLs

Allow specifying LDAP authentication parameters as RFC 4516 LDAP URLs.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2012-12-04 07:00:43 Hot Standby conflict resolution handling
Previous Message Etsuro Fujita 2012-12-04 05:52:12 Re: Patch for removng unused targets