| From: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |
| Date: | 2012-11-20 16:14:57 |
| Message-ID: | 50ABAC81.2040002@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2012-11-20 17:03 keltezéssel, Boszormenyi Zoltan írta:
> 2012-11-18 17:20 keltezéssel, Magnus Hagander írta:
>
>> The whole tar writing part of the code needs a lot more comments. It's
>> entirely unclear what the code does there. Why does the recovery.conf
>> writing code need to be split up in multiple locations inside
>> ReceiveTarFile(), for example? It either needs to be simplified, or
>> explained why it can't be simplified in comments.
I also simplified (the multiple #ifdef blocks are moved out into a function
to make the code shorter) and added comments to this function.
Best regards,
Zoltán Böszörményi
--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2012-11-20 16:35:12 | Re: [pgsql-www] Maintenance announcement for trill.postgresql.org |
| Previous Message | Boszormenyi Zoltan | 2012-11-20 16:03:59 | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |