| From: | Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: GinPageIs* don't actually return a boolean |
| Date: | 2016-02-09 16:17:07 |
| Message-ID: | 508bd3a0-b0a1-4f10-ad9c-2f86656f6e79@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On вторник, 29 сентября 2015 г. 19:02:59 MSK, Alvaro Herrera wrote:
> Andres Freund wrote:
>
>> I went through all headers in src/include and checked for macros
>> containing [^&]&[^&] and checked whether they have this hazard. Found a
>> fair number.
>>
>> That patch also changes !! tests into != 0 style.
>
> I don't think you pushed this, did you?
>
Hello hackers!
I've just run into a problem with these macro. Function ginStepRight breaks
completely when compiled using the MSVC2013 and MSVC2015 (since these
releases use C99's bools but without stdbool.h like C++).
I don't understand why the patch has not been commited yet. It seems to me
not so important !! or ! = 0, the solution is all that matters.
Thanks!
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Verite | 2016-02-09 16:21:34 | Re: [patch] Proposal for \crosstabview in psql |
| Previous Message | Daniel Verite | 2016-02-09 16:14:06 | Re: [patch] Proposal for \crosstabview in psql |