Re: pg_test_fsync output and commit_delay

> The attached simple patch alters the output produced by pg_test_fsync,
> so that we also see the average sync time per op.

Good idea. A median would be even better, but harder to calculate, I
imagine. You might consider providing a maximum, too.

> The pg_test_fsync
> docs have had minor alterations too. Hopefully, another doc patch will
> follow that builds upon this, and actually firmly recommends taking a
> particular course of action when setting commit_delay - my previous
> observations about what helped throughput, though supported by Greg
> Smith, have not been scrutinised enough just yet, I feel. For now, the
> equivocated wording of my doc alterations (that raw wal_sync_method
> file sync time might *somehow* be useful here) seems appropriate.

I'll see what I can do.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com