From: | Philip Warner <pjw(at)rhyme(dot)com(dot)au> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Giles Lean <giles(at)nemeton(dot)com(dot)au> |
Subject: | Re: pg_dump and large files - is this a problem? |
Date: | 2002-10-24 02:02:14 |
Message-ID: | 5.1.0.14.0.20021024115925.028bea28@mail.rhyme.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At 11:55 AM 24/10/2002 +1000, Philip Warner wrote:
>The only code that uses SEEK_CUR is the code to check if seek is available
>- I am ver happy to change that to SEEK_SET - I can't even recall why I
>used SEEK_CUR. The code that does the real seeks uses SEEK_SET.
Come to think of it:
ctx->hasSeek = (fseeko(AH->FH, 0, SEEK_CUR) == 0);
should be replaced by:
#ifdef HAS_FSEEK[O]
ctx->hasSeek = TRUE;
#else
ctx->hasSeek = FALSE;
#endif
Since we're now checking for it in configure, we should remove the checks
from the pg_dump code.
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-10-24 02:03:17 | Re: pg_dump and large files - is this a problem? |
Previous Message | Philip Warner | 2002-10-24 01:55:17 | Re: pg_dump and large files - is this a problem? |