| From: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Marc Cousin <cousinmarc(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Ants Aasma <ants(at)cybertec(dot)at>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] lock_timeout and common SIGALRM framework |
| Date: | 2012-07-04 16:58:44 |
| Message-ID: | 4FF47644.4050407@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2012-07-04 17:25 keltezéssel, Alvaro Herrera írta:
> Excerpts from Boszormenyi Zoltan's message of mié jul 04 07:03:44 -0400 2012:
>> 2012-07-03 23:38 keltezéssel, Alvaro Herrera írta:
>>> I don't understand why PGSemaphoreTimedLock() is not broken. I mean
>>> surely you need a bool return to let the caller know whether the
>>> acquisition succeeded or failed?
>> Well, this is the same interface PGSemaphoreTryLock() uses.
>> By this reasoning, it's also broken.
> Eh, no -- as far as I can see, PGSemaphoreTryLock returns a boolean,
> which is precisely my point.
You're right. I blame the heat for not being able to properly
read my own code.
--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2012-07-04 16:58:49 | waitpid in pg_basebackup |
| Previous Message | Joel Jacobson | 2012-07-04 16:44:54 | [PATCH] pg_dump: Sort overloaded functions in deterministic order |