| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql_fdw, FDW for PostgreSQL server |
| Date: | 2012-03-05 12:00:46 |
| Message-ID: | 4F54AAEE.6020707@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2012/03/05 18:21), Shigeru Hanada wrote:
> (2012/02/21 20:25), Etsuro Fujita wrote:
>> Please find attached an updated version of the patch.
>
> This v2 patch can be applied on HEAD cleanly. Compile completed with
> only one expected warning of scan.c, and all regression tests for both
> core and contrib modules passed.
>
> This patch allows FDWs to return multiple ForeignPath nodes per a
> PlanForeignScan call. It also get rid of FdwPlan, FDW-private
> information container, by replacing with simple List.
>
> I've reviewed the patch closely, and have some comments about its design.
Thank you for your review.
> Basically a create_foo_path is responsible for creating a node object
> with a particular Path-derived type, but this patch changes
> create_foreignscan_path to just call PlanForeignScan and return void.
> This change seems breaking module design.
create_index_path builds multiple index paths for a plain relation. How
about renaming the function to create_foreign_paths?
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2012-03-05 12:05:58 | Re: pgsql_fdw, FDW for PostgreSQL server |
| Previous Message | Simon Riggs | 2012-03-05 10:12:24 | Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation) |