| From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
|---|---|
| To: | <alvherre(at)commandprompt(dot)com> |
| Cc: | <simon(at)2ndquadrant(dot)com>,<andres(at)anarazel(dot)de>, <aidan(at)highrise(dot)ca>, <stark(at)mit(dot)edu>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 16-bit page checksums for 9.2 |
| Date: | 2012-01-04 13:41:58 |
| Message-ID: | 4F0402C60200002500044319@gw.wicourts.gov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> We don't support BLCKSZ higher than 32k anyway
Thanks for pointing that out. Then I think we should declare sum1 to
be uint and sum2 to be uint64. We can take out the "% 255" out from
where it sits in the v2 patch, and just add something like this after
the sums are generated:
sum1 %= 255;
sum2 %= 255;
Or, of course, we can just do it on the line where we combine the two
sums for the final result, if that's not too hard to read.
-Kevin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Albe Laurenz | 2012-01-04 14:27:08 | Re: review: CHECK FUNCTION statement |
| Previous Message | Kevin Grittner | 2012-01-04 13:35:19 | Re: 16-bit page checksums for 9.2 |