| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL <Pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME |
| Date: | 2011-10-12 15:24:33 |
| Message-ID: | 4E95B131.4010505@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 12.10.2011 18:20, Tom Lane wrote:
> Heikki Linnakangas<heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> On 12.10.2011 17:33, Magnus Hagander wrote:
>>> How about adding something like
>>> -- \\psql_hates_this
>>> -- rest of comment
>>>
>>> and then at least have new versions of psql find that and stop
>>> processing the file with a more useful error at that point? Or maybe
>>> that's overengineering..
>
>> Overengineering IMHO. Besides, if a psql poison comment like that
>> exists, then we'd have to be careful not to emit one elsewhere. Think
>> pg_dump, if someone puts that comment in a function body...
>
> Well, it can't be a comment, but what about a real psql command?
> See my suggestion of using \echo.
Frankly I think a comment is sufficient. We can make it more complicated
later if people are still confused.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-10-12 15:32:03 | Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME |
| Previous Message | Andrew Dunstan | 2011-10-12 15:20:34 | Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2011-10-12 15:26:06 | Re: COUNT(*) and index-only scans |
| Previous Message | Andrew Dunstan | 2011-10-12 15:20:34 | Re: [BUGS] *.sql contrib files contain unresolvable MODULE_PATHNAME |