Re: Bug with pg_ctl -w/wait and config-only directories

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "Mr(dot) Aaron W(dot) Swenson" <titanofold(at)gentoo(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug with pg_ctl -w/wait and config-only directories
Date: 2011-10-03 23:10:07
Message-ID: 4E8A40CF.8020801@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/03/2011 06:45 PM, Bruce Momjian wrote:
> Alvaro Herrera wrote:
>> Excerpts from Bruce Momjian's message of lun oct 03 17:28:53 -0300 2011:
>>> Alvaro Herrera wrote:
>>>> Well, we have the Gentoo developer in this very thread. I'm sure they
>>>> would fix their command line if we gave them a pg_ctl that worked.
>>>> Surely the package that contains the init script also contains pg_ctl,
>>>> so they would both be upgraded simultaneously.
>>> What is the fix? If they started the server by using --data-directory,
>>> pg_ctl stop has no way to find the postmaster.pid file, and hence stop
>>> the server. Are you suggesting we remove this ability?
>> I am suggesting they don't start it by using --data-directory in the
>> first place.
> Agreed. If you remove that, the logical problem goes away and it
> becomes a simple problem of dumping the contents of postgresql.conf and
> having pg_ctl (and pg_upgrade) use that. Let me look at how much code
> that would take.
>

Yeah, this pattern can be changed to have a config file that reads:

data_directory = '/path/to/data'
include '/path/to/common/config'

and I presume (or hope) that would meet your need, and not upset the FHS
purists.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aidan Van Dyk 2011-10-04 00:41:10 Re: Bug with pg_ctl -w/wait and config-only directories
Previous Message Tom Lane 2011-10-03 23:07:31 Re: Should we get rid of custom_variable_classes altogether?