| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Kris Jurka <books(at)ejurka(dot)com>, pgsql-hackers(at)postgresql(dot)org, David Fetter <david(at)fetter(dot)org> |
| Subject: | Re: New copyright program |
| Date: | 2011-08-19 23:37:29 |
| Message-ID: | 4E4EF3B9.1030407@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/19/2011 07:31 PM, Bruce Momjian wrote:
> Kris Jurka wrote:
>> Did you also try the "use Tie::File" addition in my fix because your
>> current coding doesn't work at all. The tie operation is key to actually
>> writing out the modified copyright notice. Your version just updates the
>> copyright year in memory, but never gets it back to the file.
> Ah, that did fix it; thanks. I am attached the updated committed
> copyright.pl. I also skipped symlinks.
>
It probably doesn't matter that much in this context, but I should point
out that Tie::File is not universally available. Some years ago I had to
revert its use in the buildfarm code for that reason. In general we
should try to avoid adding extra dependencies wherever possible.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-08-19 23:41:31 | Re: New copyright program |
| Previous Message | Bruce Momjian | 2011-08-19 23:31:44 | Re: New copyright program |