| From: | Yeb Havinga <yebhavinga(at)gmail(dot)com> |
|---|---|
| To: | Kohei Kaigai <Kohei(dot)Kaigai(at)EMEA(dot)NEC(dot)COM> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
| Subject: | Re: [v9.1] sepgsql - userspace access vector cache |
| Date: | 2011-07-22 10:11:52 |
| Message-ID: | 4E294CE8.7090908@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2011-07-22 11:55, Kohei Kaigai wrote:
>
>> 2) Also I thought if it could work to not remember tcontext is valid, but instead remember the consequence,
>> which is that it is replaced by "unlabeled". It makes the avc_cache struct shorter and the code somewhat
>> simpler.
>>
> Here is a reason why we hold tcontext, even if it is not valid.
> The hash key of avc_cache is combination of scontext, tcontext and tclass. Thus, if we replaced an invalid
> tcontext by unlabeled context, it would always make cache mishit and performance loss.
I see that now, thanks.
I have no further comments, and I think that the patch in it's current
status is ready for committer.
regards,
--
Yeb Havinga
http://www.mgrid.net/
Mastering Medical Data
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kohei KaiGai | 2011-07-22 12:08:40 | Re: [v9.1] sepgsql - userspace access vector cache |
| Previous Message | Kohei Kaigai | 2011-07-22 09:55:37 | Re: [v9.1] sepgsql - userspace access vector cache |