isolation tests broken for other than 'read committed'

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <pgsql-hackers(at)postgresql(dot)org>
Cc: <alvherre(at)alvh(dot)no-ip(dot)org>,<noah(at)leadboat(dot)com>
Subject: isolation tests broken for other than 'read committed'
Date: 2011-07-15 22:23:10
Message-ID: 4E20777E020000250003F3D2@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

It's been a few days since I've run through my usual builds and
tests, and I just discovered that part of my routine was broken by
this commit:

http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=846af54dd5a77dc02feeb5e34283608012cfb217

The isolation tests are broken when run against a database with
default_transaction_isolation = 'repeatable read' or 'serializable'.
(Which is ironic, really.)

Adding the attached files to src/test/isolation/expected/ causes
those stricter isolation levels to work in my tests so far, but I
get random failures in 'read committed' due to apparent randomness
in which process is chosen as the deadlock victim. I seem to
remember Noah mentioning this and a suggested fix, but the problem
in manifest in a current checkout of head.

Of course, another approach to this would be to set transaction
isolation level in the new tests. If we do that, we might want to
create tests at all three levels, for completeness.

-Kevin

Attachment Content-Type Size
fk-deadlock_1.out application/octet-stream 2.5 KB
fk-deadlock2_1.out application/octet-stream 4.0 KB
fk-deadlock2_2.out application/octet-stream 4.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-07-15 22:29:16 Re: patch for distinguishing PG instances in event log
Previous Message Tom Lane 2011-07-15 22:11:28 Re: Is there a committer in the house?