Re: Debian readline/libedit breakage

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Dave Page <dpage(at)pgadmin(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, jd(at)commandprompt(dot)com, Greg Stark <gsstark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Michael Banck <mbanck(at)debian(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Debian readline/libedit breakage
Date: 2011-02-17 17:07:17
Message-ID: 4D5D55C5.7050206@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/17/2011 11:58 AM, Bruce Momjian wrote:
> Andrew Dunstan wrote:
>>
>> On 02/17/2011 11:44 AM, Bruce Momjian wrote:
>>> Andrew Dunstan wrote:
>>>> On 02/17/2011 11:22 AM, Bruce Momjian wrote:
>>>>> psql used to use the native Windows line editing ability --- has that
>>>>> changed?
>>>> When did it? Ad what "native" windows line editing ability are you
>>>> referring to?
>>> There is native Windows editing like arrows, etc and history, though the
>>> history is not kept between sessions. If windows is now using readline,
>>> then odds are we are shipping libreadline to make that happen, and we
>>> are then linking using a supplied GPL library (and we don't have the
>>> OS-installed exception). I hope I am wrong.
>>
>> Readline has always been disabled on Windows builds AFAIK. Just look at
>> the buildfarm traces. Here's an example from
>> <http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=frogmouth&dt=2011-02-17%2015%3A30%3A03&stg=configure>
>>
>> configure: WARNING: *** Readline does not work on MinGW --- disabling
>>
>>
>> It's not used in MSVC either, IIRC.
>
> OK, I was only responding to Stephen Frost who said psql did not behave
> like other Windows apps.

I think both of you have possibly been under a misapprehension. All this
discussion about the Windows installers is entirely irrelevant to this
thread, ISTM, since there is no readline use in them.

FWIW, the only interactively usable version of psql for windows I know
of is the one that runs under Cygwin. It can be build with readline and
works as expected.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-02-17 17:13:22 Re: Debian readline/libedit breakage
Previous Message Kevin Grittner 2011-02-17 17:07:09 Re: Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.