From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
---|---|
To: | Alex Hunsaker <badalex(at)gmail(dot)com> |
Cc: | Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pl/python tracebacks |
Date: | 2011-02-12 08:50:10 |
Message-ID: | 4D5649C2.2000501@wulczer.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/02/11 04:12, Alex Hunsaker wrote:
> On Wed, Feb 9, 2011 at 02:10, Jan Urbański <wulczer(at)wulczer(dot)org> wrote:
>> On 06/02/11 20:12, Jan Urbański wrote:
>>> On 27/01/11 22:58, Jan Urbański wrote:
>>>> On 23/12/10 14:56, Jan Urbański wrote:
>>>>> Here's a patch implementing traceback support for PL/Python mentioned in
>>>>> http://archives.postgresql.org/pgsql-hackers/2010-12/msg01991.php. It's
>>>>> an incremental patch on top of the plpython-refactor patch sent eariler.
>>>>
>>>> Updated to master.
>>>
>>> Updated to master again.
>>
>> Once more.
>
> In PLy_traceback fname and prname look like they will leak (well as
> much as a palloc() in an error path can leak I suppose).
But they're no palloc'd, no? fname is either a static "<module"> string,
or PyString_AsString, which also doesn't allocate memory, AFAIK. proname
is also a static string. They're transferred to heap-allocated memory in
appendStringInfo, which gets pfreed after emitting the error message.
> Marking as Ready.
Thanks!
Jan
From | Date | Subject | |
---|---|---|---|
Next Message | Alex Hunsaker | 2011-02-12 09:00:30 | Re: pl/python tracebacks |
Previous Message | Oleg Bartunov | 2011-02-12 08:39:01 | Re: btree_gist (was: CommitFest progress - or lack thereof) |