From: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: sepgsql contrib module |
Date: | 2011-01-26 03:23:45 |
Message-ID: | 4D3F93C1.1060400@ak.jp.nec.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
(2011/01/24 12:49), Robert Haas wrote:
> On Sun, Jan 23, 2011 at 9:56 PM, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
>> On Sun, Jan 23, 2011 at 8:53 PM, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
>>> 2011/1/21 KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com>:
>>>> The attached patch is a revised version.
>>>
>>> I've committed this. Cleanup coming...
>>
>> Yikes. On further examination, exec_object_restorecon() is pretty
>> bogus. Surely you need some calls to quote_literal_cstr() in there
>> someplace.
>
Are you concerning about the object name being supplied to
selabel_lookup_raw() in exec_object_restorecon()?
I also think this quoting you suggested is reasonable.
>> And how about using getObjectDescriptionOids() for the
>> error message, instead of the entirely bogus construction that's there
>> now?
>
It seems to me a good idea. I'll try to revise corresponding code.
> Also, shouldn't a bunch of these messages end in ": %m"?
>
When these messages are because of unexpected operating system errors,
such as fails in communication with selinux, the "%m" will give us good
suggestions.
I'll submit these fixes within a few days, please wait for a while.
Thanks,
--
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2011-01-26 03:32:24 | Re: Per-column collation, the finale |
Previous Message | Noah Misch | 2011-01-26 03:22:42 | Re: ALTER TYPE 2: skip already-provable no-work rewrites |