Re: Streaming base backups

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Streaming base backups
Date: 2011-01-15 15:35:34
Message-ID: 4D31BEC6.7080804@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15.01.2011 17:30, Tom Lane wrote:
> Heikki Linnakangas<heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> BTW, I just spotted a small race condition between creating a new table
>> space and base backup. We take a snapshot of all the tablespaces in
>> pg_tblspc before calling pg_start_backup(). If someone creates a new
>> tablespace and puts some data in it in the window between base backup
>> acquiring the list tablespaces and starting the backup, the new
>> tablespace won't be included in the backup.
>
> So what? The needed actions will be covered by WAL replay.

No, they won't, if pg_base_backup() is called *after* getting the list
of tablespaces.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-01-15 15:36:48 Re: Bug in pg_describe_object, patch v2
Previous Message Greg Smith 2011-01-15 15:31:05 Re: Spread checkpoint sync