Re: GiST insert algorithm rewrite

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Greg Stark <gsstark(at)mit(dot)edu>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
Subject: Re: GiST insert algorithm rewrite
Date: 2011-01-09 19:38:06
Message-ID: 4D2A0E9E.8080603@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09.01.2011 07:05, Tom Lane wrote:
> I just found out that the "benchmark" test script in
> contrib/intarray/bench/ crashes HEAD in gistdoinsert() --- it looks like
> it's trying to pop to a stack entry that isn't there.
>
> Run it per the instructions in the intarray documentation:
>
> $ createdb TEST
> $ psql TEST< ../_int.sql
> ...
> $ ./create_test.pl | psql TEST
> CREATE TABLE
> CREATE TABLE
> CREATE INDEX
> CREATE INDEX
> server closed the connection unexpectedly
> This probably means the server terminated abnormally
> before or while processing the request.
> connection to server was lost
>
> The script generates randomized data, so possibly it won't fail every
> time, but it failed three out of three times for me. The changes I'm
> about to commit in intarray don't seem to make any difference.

Thanks, fixed. Apparently my testing never hit the case where an update,
rather than an insert, into the root page causes it to split.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-01-09 21:10:25 hstore ?& operator versus mathematics
Previous Message Pavel Stehule 2011-01-09 19:13:58 multiset patch review