| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Complier warnings on mingw gcc 4.5.0 |
| Date: | 2010-12-16 00:44:21 |
| Message-ID: | 4D0960E5.8050104@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/15/2010 07:24 PM, Tom Lane wrote:
>
> So I concur with the previous suggestions:
>
> 1. Make this problem go away by forcing use of our getopt code on
> mingw.
>
> 2. Make sure we reset optreset when using our code. (Probably not
> really necessary, but let's just be careful.)
>
> Should we backpatch either of these things?
>
>
Yes. We need it to back at least to 9.0.
I believe #2 is in fact necessary. When I tried just #1 before it
failed. What's the best way to do #2 cleanly?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2010-12-16 00:57:19 | Re: Complier warnings on mingw gcc 4.5.0 |
| Previous Message | Tom Lane | 2010-12-16 00:24:53 | Re: Complier warnings on mingw gcc 4.5.0 |