Re: Complier warnings on mingw gcc 4.5.0

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Complier warnings on mingw gcc 4.5.0
Date: 2010-12-16 00:09:06
Message-ID: 4D0958A2.40905@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/15/2010 06:42 PM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> Mingw code attached.
> Hm, where did you get this? Because it does have optreset, albeit in a
> gratuitously ABI-incompatible fashion:
>
>> #ifdef _BSD_SOURCE
>> /*
>> * BSD adds the non-standard `optreset' feature, for reinitialisation
>> * of `getopt' parsing. We support this feature, for applications which
>> * proclaim their BSD heritage, before including this header; however,
>> * to maintain portability, developers are advised to avoid it.
>> */
>> # define optreset __mingw_optreset
>>
>> extern int optreset;
>> #endif
> However, I pulled down the allegedly current mingw source tarball from
> sourceforge, and what I found in it is an older version that has *not*
> got that change. The CVS tree there doesn't seem to have it either.
> So I'm disinclined to want to rely on setting _BSD_SOURCE, as I first
> thought might be the answer --- it looks to me like only some versions
> of mingw will respond to that.
>
>

I downloaded
<http://softlayer.dl.sourceforge.net/project/mingw/MinGW/BaseSystem/RuntimeLibrary/MinGW-RT/mingwrt-3.18/mingwrt-3.18-mingw32-src.tar.gz>
which is allegedly the source for the latest released runtime.

The section you cite is indeed in my system's getopt.h.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-12-16 00:24:53 Re: Complier warnings on mingw gcc 4.5.0
Previous Message Tom Lane 2010-12-15 23:42:12 Re: Complier warnings on mingw gcc 4.5.0