Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+
Date: 2010-12-07 02:05:12
Message-ID: 4CFD9658.6090304@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> Whether it's complex or not isn't really the issue. The issue is that
> what test_fsync is testing had better match what the backend does, or
> people will be making choices based on not-comparable test results.
> I think we should have test_fsync just automatically fold in O_DIRECT
> the same way the backend does.

OK, patch coming then. Right now test_fsync aborts when O_DIRECT fails.
What should I have it do instead?

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-12-07 02:05:28 Re: We really ought to do something about O_DIRECT and data=journalled on ext4
Previous Message Josh Berkus 2010-12-07 02:04:02 Re: We really ought to do something about O_DIRECT and data=journalled on ext4