From: | Craig Ringer <craig(at)postnewspapers(dot)com(dot)au> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files) |
Date: | 2010-11-23 14:02:01 |
Message-ID: | 4CEBC959.9080904@postnewspapers.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>> However, I am not clear what benefit we get from moving this into core
>> in 9.1. If it's still going to require a full postmaster restart, the
>> GUC you have to change may as well be shared_preload_libraries as a
>> new one.
There's no reason it should require a postmaster restart. New backends
spawned after the handler is turned on would enable it, and existing
backends could be signalled to enable it as well.
> on-by-default is what we gain. I think that's fairly big...
More than that. If a crash handler is in core, then:
- It can be inited much earlier, catching crashes that happen during
loading of libraries and during later backend init; and
- It's basically free when the cost of shared library loading is
removed, so it can be left on in production or even be on by default. I
need to do some testing on this, but given the apparently near-zero cost
of initing the handler I won't be surprised if testing a GUC to see if
the handler should be on or not costs more than loading it does.
I still wouldn't support on-by-default because you'd need an automatic
process to weed out old crash dumps or limit the number stored. That's a
bigger job. So I think the admin should have to turn it on, but it'd be
good to make it easy to turn on in production without a restart; I don't
see why that'd be hard.
I'll try to put together a patch that does just that, time permitting.
Things are kind of hectic ATM.
--
Craig Ringer
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2010-11-23 14:05:01 | Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files) |
Previous Message | Shigeru HANADA | 2010-11-23 12:22:17 | Re: SQL/MED estimated time of arrival? |