Re: Git cvsserver serious issue

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Aidan Van Dyk <aidan(at)highrise(dot)ca>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Git cvsserver serious issue
Date: 2010-10-08 01:52:33
Message-ID: 4CAE7961.30007@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: buildfarm-members pgsql-hackers

On 10/07/2010 03:37 PM, Magnus Hagander wrote:
> On Thu, Oct 7, 2010 at 21:31, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>>
>> On 10/07/2010 10:11 AM, Magnus Hagander wrote:
>>>> OTOH, this patch seems pretty small and simple to maintain.
>>> True, it is rather small.
>>>
>>> Does anybody know if there's an automated way to maintain that on
>>> freebsd ports, and if so, how that works? I want to be *sure* we can't
>>> accidentally upgrade git-cvsserver *without* the patch, since that is
>>> a security issue.
>>>
>> Why not just make a local copy somewhere else and patch and run that? It's
>> just a Perl script, no?
> Yeah, but then we have to remember to manually patch that one when
> somebody *else* finds/fixes a security issue. We have automatic
> monitoring on the ports stuff to detect when that happens..

There's a simpler solution which I have just tested. Instead of
patching, use the Pg driver instead of SQLite. Set the dbname to %m. If
the database doesn't exist the cvs checkout will fail. So we just set up
databases for the modules we want to export (master and RELn_m_STABLE
for the live branches).

cheers

andrew

In response to

Responses

Browse buildfarm-members by date

  From Date Subject
Next Message Andrew Dunstan 2010-10-08 03:18:34 Re: Git cvsserver serious issue
Previous Message Magnus Hagander 2010-10-07 19:37:48 Re: Git cvsserver serious issue

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-10-08 02:01:54 Re: Issues with Quorum Commit
Previous Message Robert Haas 2010-10-08 01:52:26 Re: levenshtein_less_equal (was: multibyte charater set in levenshtein function)