Re: Reducing walreceiver latency with a latch

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Thom Brown <thom(at)linux(dot)com>
Subject: Re: Reducing walreceiver latency with a latch
Date: 2010-09-14 08:51:01
Message-ID: 4C8F3775.5090308@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 14/09/10 05:02, Fujii Masao wrote:
> + /*
> + * Walreceiver sets this latch every time new WAL has been received and
> + * fsync'd to disk, allowing startup process to wait for new WAL to
> + * arrive.
> + */
> + Latch receivedLatch;
>
> I think that this latch should be available for other than walreceiver -
> startup process communication. For example, backend - startup process
> communication, which can be used for requesting a failover via SQL function
> by users in the future. What about putting the latch in XLogCtl instead of
> WalRcv and calling OwnLatch at the beginning of the startup process instead
> of RequestXLogStreaming?

Yes, good point. I updated the patch along those lines, attached.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

Attachment Content-Type Size
walreceiver-latch-3.patch text/x-diff 5.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2010-09-14 08:51:20 Re: security label support, revised
Previous Message Fujii Masao 2010-09-14 08:35:23 Re: pg_ctl emits strange warning message