From: | Michael Haggerty <mhagger(at)alum(dot)mit(dot)edu> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Max Bowsher <maxb(at)f2s(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: git: uh-oh |
Date: | 2010-09-06 03:41:06 |
Message-ID: | 4C8462D2.2020404@alum.mit.edu |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Michael Haggerty <mhagger(at)alum(dot)mit(dot)edu> writes:
>> CVS does not record when a branch was created or by whom. If a git
>> commit has to be created for such events, cvs2git attributes them to a
>> configurable username, which Max has set to be "pgsql". It chooses the
>> latest possible timestamp that is consistent with other (timestamped)
>> changesets that depend on it.
>
>> Does cvs2cl do something better? If so, how?
>
> I suspect what it's doing is attributing the branch creation to the user
> who makes the first commit on the branch for that file. In general I'd
> expect that to give a reasonable result --- better than choosing a
> guaranteed-to-be-wrong constant value anyway ;-)
On the contrary, I prefer an obvious indication of "I don't know" to a
value that might appear to be authoritative but is really just a guess.
It could be that one user copied the file verbatim to the branch and a
second user changed the file as part of an unrelated change.
The "default default" value for these commits is "cvs2svn" (in your case
"cvs2git would probably be more appropriate), which I like because it
makes it clearer than "pgsql" that the commit was generated as part of a
conversion.
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-09-06 04:09:46 | Re: git: uh-oh |
Previous Message | Tom Lane | 2010-09-06 03:04:13 | Re: git: uh-oh |