Re: Miscellaneous changes to plperl [PATCH]

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>
Cc: Alex Hunsaker <badalex(at)gmail(dot)com>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Miscellaneous changes to plperl [PATCH]
Date: 2010-01-23 23:26:04
Message-ID: 4B5B858C.9070301@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tim Bunce wrote:
>> - } keys %$imports;
>> + } sort keys %$imports;
>>
>
> Ok, good.
>
>
>> - my $funcsrc;
>> - $funcsrc .= qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog $src } ];
>> - #warn "plperl mkfuncsrc: $funcsrc\n";
>> - return $funcsrc;
>> + return qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog $src } ];
>>
>>
>
> Ok. (I don't think that'll clash with any later patches.)
>
>
> So, what now? Should I resend the patch with the two 'ok' changes above
> included, or can the committer make those very minor changes?
>
>
>

I'll pick these up, if Alex marks it ready for committer.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-01-23 23:58:11 Re: commit fests
Previous Message Robert Haas 2010-01-23 23:20:23 Re: commit fests