Re: Compiling HEAD with -Werror int 64-bit mode

From: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Postgresql-Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Compiling HEAD with -Werror int 64-bit mode
Date: 2009-12-16 01:56:05
Message-ID: 4B283E35.4060202@phlo.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15.12.09 23:38 , Tom Lane wrote:
> Peter Eisentraut<peter_e(at)gmx(dot)net> writes:
>> So to summarize, this is just a bad idea. Creating a less obscure
>> way to use -Werror might be worthwhile, though.
>
> I suppose we could add "--with-Werror" but it seems pretty
> specialized to me. A more appropriate solution would allow the user
> to provide flags that get added to CFLAGS only after we do all the
> configure tests (implying that it's on the user's head that these
> flags are right and don't break anything, but then again that's
> pretty much true of up-front CFLAGS too). And that basically
> describes COPTS ... the only thing lacking is documentation.

For what it's worth, I agree. Though we might want to arrange for
configure to store the value of COPT somewhere so that
COPT="-Werror" ./configure
make
works which it currently doesn't seem to.

best regards,
Florian Pflug

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kurt Harriman 2009-12-16 02:30:08 Re: Patch: Remove gcc dependency in definition of inline functions
Previous Message Jeff Davis 2009-12-16 01:05:33 Re: Range types