| From: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Greg Smith <greg(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: EXPLAIN BUFFERS |
| Date: | 2009-12-11 16:36:27 |
| Message-ID: | 4B22750B.2040408@timbira.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas escreveu:
> On Thu, Dec 10, 2009 at 9:35 PM, Takahiro Itagaki
> <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>> Anyway, a revised patch according to the comments is attached.
>> The new text format is:
>> Buffers: shared hit=675 read=968, temp read=1443 written=1443
>> * Zero values are omitted. (Non-text formats could have zero values.)
>> * Rename "Blocks:" to "Buffers:".
>> * Remove parentheses and add a comma between shared, local and temp.
>
> I did a bit of copy-editing of your doc changes to make the English a
> bit more correct and idiomatic. Slightly revised patch attached for
> your consideration. The output format looks really nice (thanks for
> bearing with me), and the functionality is great.
>
Please, document that zero values are omitted in the text format. It seems
intuitive but could be surprise because zero values are in non-text formats.
--
Euler Taveira de Oliveira
http://www.timbira.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2009-12-11 16:36:41 | Re: SE-PostgreSQL/Lite Review |
| Previous Message | Joshua Brindle | 2009-12-11 16:33:09 | Re: SE-PostgreSQL/Lite Review |