Re: WIP: log query in auto-explain

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: log query in auto-explain
Date: 2009-11-22 23:05:28
Message-ID: 4B09C3B8.5050801@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> I put the attached together a while ago and neglected to send it.
>> Basically it includes the text of the query being explained in the
>> explain output.
>>
>
> I'm pretty certain this will dump core in some contexts --- you should
> not assume that sourceText is always available.
>

Ok, I guess I can insert a check that the sourceText is not null. I
wonder what we are supposed to take an explanation to mean if we can't
say what it is we're explaining.

> Should we be worried about security implications of displaying the query
> text?
>
>

If it is dangerous then surely so is the explanation.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2009-11-22 23:26:32 Re: Updating column on row update
Previous Message Stephan Szabo 2009-11-22 22:49:52 Re: Partitioning option for COPY