Re: Using results from INSERT ... RETURNING

From: Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Using results from INSERT ... RETURNING
Date: 2009-10-10 08:42:45
Message-ID: 4AD04905.40304@cs.helsinki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Applied with a moderate amount of editorialization.

Thank you!

> Notably, I didn't
> like what you'd done with the EvalPlanQual stuff, and after a bit of
> reflection decided that the right thing was to teach EvalPlanQual to
> execute just the desired subplan.

I didn't really like that either but I didn't have any good ideas. This
is a lot better.

> Also, I put back the marking of
> the ModifyTuple node with its target relations, which you'd removed
> in the v4 patch --- I'm convinced that that will be necessary in some
> form or other later, so taking it out now seemed like moving backward.

Ok.

> 2. Move actual execution of (non-deferred) AFTER triggers inside
> ModifyTuple. This might be a good idea in order to have the most
> consistent results for a series of WITH queries, but I'm not sure.

This definitely seems like the best option to me.

Regards,
Marko Tiikkaja

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2009-10-10 12:07:46 Re: Idle connection timeout
Previous Message Jaime Casanova 2009-10-10 07:45:35 Re: GRANT ON ALL IN schema