| From: | Andrew Chernow <ac(at)esilo(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Merlin Moncure <mmoncure(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PQinitSSL broken in some use casesf |
| Date: | 2009-02-13 18:13:06 |
| Message-ID: | 4995B832.1030309@esilo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas wrote:
> On Fri, Feb 13, 2009 at 12:06 PM, Andrew Chernow <ac(at)esilo(dot)com> wrote:
>> Patch attached.
>>
>> One thing I noticed is the ssl_open_connections variable is ref counting
>> connections when pq_initssllib is true. But, it now only affects crypto
>> library init and cleanup calls. Point is, ref counting is only needed if
>> pq_initcryptolib is true and it should be renamed to
>> crypto_open_connections. I didn't do this in the patch. Its the same old
>> name and the counter is incremented if pq_initssllib or pq_initcryptolib is
>> true. Please advise.
>
> I'll review this in more detail when I have a chance, but it certainly
> won't be committable without doc changes, and it's probably best if
> you write those and include them in the patch.
>
> ...Robert
>
>
Okay. Added docs in the same place PQinitSSL is. Apparently, initssl
doesn't have formal func docs.
--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| initcrypto.patch | text/plain | 9.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Chernow | 2009-02-13 18:33:41 | Re: PQinitSSL broken in some use casesf |
| Previous Message | Robert Haas | 2009-02-13 18:00:49 | Re: PQinitSSL broken in some use casesf |