Re: Patch to add Windows 7 support

Peter Eisentraut wrote:
> On Tuesday 27 January 2009 12:34:56 Dave Page wrote:
>> I'm not entirely sure what has change in the SCM to cause this yet
>> (Windows 7 documentation is somewhat thin on the ground at the
>> moment), but the patch avoids theporblem by only setting
>> JOB_OBJECT_UILIMIT_HANDLES on earlier OSs.

Does the SCM just terminate the process, or does it at some point give
us an error code?

> Doesn't this effectively mean, we relax the security settings because we don't
> understand why we are getting errors? Sounds fishy.

In theory, yes. However, it only affects USER handles, which is
basically windows, buttons etc. So what it basically means is that a
hacked PostgreSQL process can be used to send messages, for example, to
other windows running in the same session. Which only affects things if
pg is started from the commandline, and not as a service.

I don't think it's enough that we need to care about it really. I'm
thinking we could perhaps even just never set that, and not bother with
the version check...

But perhaps we should set it only when launching as a service, and not
when running from the commandline?

//Magnus