From: | Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: SQL/MED compatible connection manager |
Date: | 2008-12-12 13:59:51 |
Message-ID: | 49426E57.4050000@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> Now the way I read the FDWs you provide (default and pgsql), you are
> creating your own API for initialization and options validation that is
> not in the standard. That would appear to contradict the idea of a
> standard interface. I understand that option validation is useful, and
> I don't see anything about it in the standard, but should we break the
> API like that? What are your designs about this?
>
Hmm, in that perspective it would make sense to make the InitializeFdw
function optional (it was, before I got worried about library reloads).
If no InitializeFdw is present, connection lookup and option validation
are disabled. All of the standard defined FDW functions are fetched by
load_external_function. This way we could have the additional features
and still be able to load standard conforming FDW's.
Actually it would make sense to use _PG_init instead of InitializeFdw.
This way it'd be called automatically on library load, the parameter(s)
would be passed in globals though.
regards,
Martin
From | Date | Subject | |
---|---|---|---|
Next Message | Rod Taylor | 2008-12-12 14:00:52 | Re: WIP: default values for function parameters |
Previous Message | Aidan Van Dyk | 2008-12-12 13:57:12 | Re: Sync Rep: First Thoughts on Code |