From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | set_pglocale_pgservice considered harmful |
Date: | 2006-09-11 17:59:03 |
Message-ID: | 4917.1157997543@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Why in the world is set_pglocale_pgservice() located in src/port/path.c?
I was just trying to find out why ecpg is failing on the Darwin
buildfarm members since I modified the arrangements for pulling in extra
libraries for AIX. The answer is that ecpglib needs path.c for
last_dir_separator(), and path.c contains set_pglocale_pgservice(),
which pulls in both exec.c and bindtextdomain/textdomain/gettext.
IOW libintl gets pulled into ecpglib links for no reason whatsoever
--- it certainly isn't being used by ecpglib itself.
I think set_pglocale_pgservice should either be moved to exec.c or put
into its own separate src/port/ file. Comments?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Stefan Kaltenbrunner | 2006-09-11 18:03:08 | Re: Buildfarm vs. Linux Distro classification |
Previous Message | Gregory Stark | 2006-09-11 17:57:41 | Re: Fixed length data types issue |