Review: psql-wrap-formatting/Unicode UTF-8 table formatting for psql text output

From: gabrielle <gorthx(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: rleigh(at)codelibre(dot)net
Subject: Review: psql-wrap-formatting/Unicode UTF-8 table formatting for psql text output
Date: 2009-11-19 02:36:44
Message-ID: 48bb92b0911181836w65139f08x7eb124d964d7a9af@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Overview:
Patch to make data output that includes newlines & wrapped lines
consistent with the headers for that data.
Link: https://commitfest.postgresql.org/action/patch_view?id=220

Submission review:
* is in context diff
* applies cleanly to current HEAD
* includes its own test .sql file to verify new output
* includes appropriate doc patches

Usability review:
* the patch does indeed do what it says
* maintains backward compatibility, should the end-user desire it
* included tests perform as advertised

Coding review:
* looks good to me
* fits in with the surrounding code
* no compiler warnings, no crashes
* complete & understandable docs

Personally, I think this rocks. It really improves the readability of
query output.

gabrielle
--
on behalf of the PDXPUG Patch Review Team (Dan, Mark, John, Brad, & me)

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-11-19 02:49:21 Re: Listen / Notify - what to do when the queue is full
Previous Message Andrew Dunstan 2009-11-19 02:21:18 Re: "Not safe to send CSV data" message