Re: [patch] fix dblink security hole

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [patch] fix dblink security hole
Date: 2008-09-22 01:55:33
Message-ID: 48D6FB15.4080409@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>> If the return value is NULL, use errmsg if you'd like. I'd guess in most
>> instances you don't even need to bother freeing errmsg as it is in a
>> limited life memory context.
>
> Uh, you're confusing the backend environment with libpq's much more
> spartan lifestyle. errmsg will be malloc'd and it will *not* go away
> unless the caller free()s it.

Yup, just figured that out. Otherwise OK with it?

Joe

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-09-22 02:00:01 Re: [patch] fix dblink security hole
Previous Message Tom Lane 2008-09-22 01:53:06 Re: [patch] fix dblink security hole