Re: [PATCHES] libpq type system 0.9a

From: Andrew Chernow <ac(at)esilo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] libpq type system 0.9a
Date: 2008-04-09 17:29:48
Message-ID: 47FCFD0C.8030305@esilo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
>
> Hmm. I guess it wouldn't be completely out of the question to expose
> the contents of PGresult as part of libpq's API. We haven't changed it
> often, and it's hard to imagine a change that wouldn't be associated
> with a major-version change anyhow. We could do some things to make it
> a bit more bulletproof too, like change cmdStatus from fixed-size array
> to pointer to allocated space so that CMDSTATUS_LEN doesn't become
> part of the API.
>
> Alternatively, we could keep it opaque and expose a bunch of manipulator
> routines, but that might be a lot more cumbersome than it's worth.
>
> regards, tom lane
>

How about a proxy header (if such an animal exists). Maybe it is
possible to take pg_result, and all structs it references, and put it in
result-int.h. libpq-int.h would obviously include this. Also, any
external library, like libpqtypes, that need direct access to a result
can include result-int.h. This keeps pg_result and referenced structs
out of libpq-fe.h. From a libpq user's viewpoint, nothing has changed.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2008-04-09 17:31:49 Re: Commit fest queue
Previous Message Tom Lane 2008-04-09 17:27:57 Re: Concurrent psql API

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-04-09 18:14:46 Re: Fix for win32 stat() problems
Previous Message Tom Lane 2008-04-09 17:27:57 Re: Concurrent psql API